-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define telemetry-atomic-exempt
annotation. Add telemetry-atomic-exempt
annotation to AFT counters containers
#1186
Conversation
/gcbrun |
No major YANG version changes in commit 05160c6 |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment to consider, otherwise LGTM
extension telemetry-atomic-exempt { | ||
description | ||
"The telemetry-atomic-exempt annotation is specified in the context | ||
of a subtree (container, or list), and indicates that all nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think telemetry-atomic-exempt could also be defined for an individual node. While I don't have a use case for this at the moment, it seems allowing it is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Updated the description to have "node".
Please also update the version statements for the many submodules. You can see the list in the CI check results which are failing: https://gist.github.com/OpenConfigBot/7b24c6fe579a3665eb73ad941f55d7e7 |
Setting last call to Oct 24, 2024 |
/gcbrun |
Change Scope
telemetry-atomic-exempt
annotation.telemetry-atomic-exempt
annotation to AFT counters containers/groupingAFT atomic and counters issue