Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define telemetry-atomic-exempt annotation. Add telemetry-atomic-exempt annotation to AFT counters containers #1186

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

romeyod
Copy link
Contributor

@romeyod romeyod commented Sep 19, 2024

  • (M) aft/openconfig-aft-common.yang
  • (M) openconfig-extensions.yang

Change Scope

  • Define telemetry-atomic-exempt annotation.
  • Add telemetry-atomic-exempt annotation to AFT counters containers/grouping
  • This change is backwards compatible

AFT atomic and counters issue

@romeyod romeyod requested a review from a team as a code owner September 19, 2024 19:09
@dplore
Copy link
Member

dplore commented Sep 20, 2024

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Sep 20, 2024

No major YANG version changes in commit 05160c6

@dplore dplore self-assigned this Sep 25, 2024
@dplore
Copy link
Member

dplore commented Sep 25, 2024

This makes sense to me. @LimeHat @nandan-arista @earies @rgwilton for comment

@dplore
Copy link
Member

dplore commented Oct 8, 2024

/gcbrun

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to consider, otherwise LGTM

extension telemetry-atomic-exempt {
description
"The telemetry-atomic-exempt annotation is specified in the context
of a subtree (container, or list), and indicates that all nodes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think telemetry-atomic-exempt could also be defined for an individual node. While I don't have a use case for this at the moment, it seems allowing it is useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Updated the description to have "node".

@dplore dplore added the last-call PR that is in final review before merging. label Oct 8, 2024
@dplore
Copy link
Member

dplore commented Oct 8, 2024

Please also update the version statements for the many submodules. You can see the list in the CI check results which are failing: https://gist.github.com/OpenConfigBot/7b24c6fe579a3665eb73ad941f55d7e7

@dplore
Copy link
Member

dplore commented Oct 8, 2024

Setting last call to Oct 24, 2024

@dplore
Copy link
Member

dplore commented Oct 10, 2024

/gcbrun

@dplore dplore merged commit 35b7954 into openconfig:master Oct 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call PR that is in final review before merging. non-breaking
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants