Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature paused recurring contributions as active #558

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

znarf
Copy link
Member

@znarf znarf commented Apr 15, 2024

No description provided.

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good quick fix, though I'm still concerned by this searchTerm thing

@@ -48,6 +48,25 @@ const contributorsQuery = gqlV2/* GraphQL */ `
createdAt
}
}
pausedRecurringContributions: orders(
searchTerm: $slug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again, I think we should rather introduce an account parameter as searchTerm could return wrong values (eg. "opensource" could return an order with description "Contribution to Babel's OpenSource Fund").

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at that.

@znarf znarf merged commit b3ece41 into main Apr 16, 2024
4 checks passed
@znarf znarf deleted the activeRecurringContribution-paused branch April 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants