fix(core): catch missing reduced costs and shadow prices. #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple code change in the
get_solution
function incore/solution.py
catches all exceptions regarding reduced costs and shadow prices not being available. If the latest change in the downstream dependency optlang (opencobra/optlang#259) is used here, then the general exception can be replaced with a ValueError which would be more specific and still solver agnostic. Still,Exception
should catch GurobiErrors as well as ValueErrors and only in the case where thoseRC
andPi
variables are actually accessed, therefore I don't deem it problematic if it would stay like that.I ran the tests via tox and also tested both minimal working examples of issue numbers #1381 and #1372, both are now working just fine.