fix: reaction bounds in _add_cycle_free function #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not really sure about what is causing the error with lint and how to fix that. |
|
Hey, Thank you for the contribution. The lint errors are not related to your lines of code, but there's probably a new version of black causing this. @cdiener the code changes make sense to me, but you're probably most familiar with the code. Can you take a look, please? |
cdiener
approved these changes
Feb 12, 2024
|
Nice, is there anything else I should do? |
Sorry for the delay, currently in the middle of a move. But that looks mostly good. Can you resolve the missing checkpoints? New tests are not necessary here but a mention in the release notes would be required. |
Merged
…ng to the description in CycleFreeFlux paper
cdiener
force-pushed
the
fix-bounds-_add_cycle_free
branch
from
e57eddb
to
ae369af
Compare
|
I just read the notification, thanks for finishing this for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: reaction bounds in _add_cycle_free function are assigned according to the description in CycleFreeFlux paper
In _add_cycle_free function, when the original flux is > 0, the ub is forced to be the maximum value between the flux and the reaction ub. It should be the minimum between these 2 values according to the CycleFreeFlux paper. The same happens with the lb of reactions with flux < 0. It has been modified to be the maximum between the original flux and the reaction lb.