Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

205 correct person detail link #221

Closed
wants to merge 7 commits into from
Closed

205 correct person detail link #221

wants to merge 7 commits into from

Conversation

coreyar
Copy link
Contributor

@coreyar coreyar commented Jun 9, 2018

This should close out issue #205.

I found that this link was available and correct from the person dict returned by web_scraper.councilMembers(). I refactored the script so that this url could be added to the person object.

@fgregg
Copy link
Contributor

fgregg commented Jul 12, 2018

Hi @coreyar it looks like you only want to have this commit in yoru PR 0476c4c

If you'd like to add the Nasheville scrapers, please do that in a separate PR.

@coreyar
Copy link
Contributor Author

coreyar commented Jul 12, 2018

🙈Whoops! Let me make a correct PR.

@coreyar coreyar closed this Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreyar @fgregg