Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor grammar issues #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

popmechanic
Copy link

No description provided.

@Flavien
Copy link
Member

Flavien commented Nov 15, 2015

Thanks a lot for the corrections. The changes look good to me. There is just one small thing before I merge: can you start the commit message with a verb in infinitive form, for consistency with the rest of the project, and with other open source projects, for example:

  • Make minor gramatical edits or
  • Fix minor grammatical errors

Also, I think grammatical should have two ms.

@popmechanic popmechanic changed the title Minor gramatical edits Fix minor grammar issues Nov 19, 2015
@popmechanic
Copy link
Author

Excellent, thanks for the feedback. I amended the commit messages (and corrected the spelling of grammar;).

@Flavien
Copy link
Member

Flavien commented Nov 19, 2015

Can you also change the commit title? You can use git amend to do that, then you'll need to force push to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants