Fix SpanCaptureReporter test spillage (#22) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please release 0.4.1 after merge, because this is blocking work on opencensus-beam/opencensus_absinthe#17, opencensus-beam/opencensus_absinthe#21, and others. |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 97.91% 98.24% +0.32%
==========================================
Files 5 5
Lines 48 57 +9
==========================================
+ Hits 47 56 +9
Misses 1 1
Continue to review full report at Codecov.
|
* Discard spans started before `attach/0` was called * Trigger `report/2` and wait 1ms before `collect/0` * Set and advise `send_interval_ms: 100` to reduce unpredictability of `report/2` time, which with `send_interval_ms: 1` would sometimes wait until after `detach/0`
garthk
force-pushed
the
fix/span-capture-spillage-#22
branch
from
1d1cd24 to
3af2473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discard spans started before
attach/0was calledTrigger
report/2and wait 1ms beforecollect/0Set and advise
send_interval_ms: 100to reduce unpredictability ofreport/2time, which withsend_interval_ms: 1would wait until afterdetach/0