Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store VCF ID value as a FileEntry attribute #176

Open
j-coll opened this issue Feb 14, 2020 · 1 comment
Open

Store VCF ID value as a FileEntry attribute #176

j-coll opened this issue Feb 14, 2020 · 1 comment
Assignees
Milestone

Comments

@j-coll
Copy link
Member

j-coll commented Feb 14, 2020

In the current implementation, we are losing the track between an ID (column ID from the VCF) and its file. This is not a problem when the ID has a rs , but in case of containing other internal Ids (see https://github.com/Illumina/manta), it needs to be related to the original file.

This ID should be added to the FileEntry attribute, together with the FILTER and QUAL, using another reserved key ID

chr1  rs1234  1000  A   C   100  PASS   DP=30
{
  id: "chr1:1000:A:C",
  names: ["rs1234"],
  studies: [{
    files : [{
      attributes: {
        "ID": "rs1234",
        "QUAL": "100",
        "FILTER": "PASS",
        "DP": "30"
      }
    }]
  }]
}
@j-coll j-coll self-assigned this Feb 14, 2020
@j-coll j-coll added this to the v2.0.0 milestone Mar 5, 2020
j-coll added a commit that referenced this issue Mar 18, 2020
@imedina
Copy link
Member

imedina commented Mar 19, 2020

Nice tickt, just one question: variant.names will always contain the union of all VCF IDs found?

@imedina imedina changed the title Store vcf ID value as a FileEntry attribute Store VCF ID value as a FileEntry attribute Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants