Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set Accept header to text/event-stream for completion streaming #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathetake
Copy link

@mathetake mathetake commented Oct 23, 2024

Previously, the standard Accept header was set to application/json unconditionally.
However, streaming response returns content-type: text/event-stream following
the specification of server-sent-events.

This correctly sets the Accept header to it accordingly in order to comply with the
standard. The exact same problem exists in other SDKS (e.g. openai/openai-node#375, openai/openai-python#1815)

@mathetake mathetake requested a review from a team as a code owner October 23, 2024 16:47
completion.go Show resolved Hide resolved
@mathetake mathetake changed the title Correctly set Accept header to text/event-stream for streaming Correctly set Accept header to text/event-stream for completion streaming Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants