Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building directly from git #1344

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Support building directly from git #1344

merged 4 commits into from
Jul 31, 2023

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Jun 13, 2023 •
edited
Loading

Fixes: #1343

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 13, 2023
View reviewed changes
osc/store.py Fixed Show fixed Hide fixed
osc/store.py Fixed Show fixed Hide fixed
@dmach dmach changed the title Support for building directly from git Support building directly from git Jun 14, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 65.83% and project coverage change: +0.27% 🎉

Comparison is base (99fb94e) 28.93% compared to head (5a2ebda) 29.20%.
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   28.93%   29.20%   +0.27%     
==========================================
  Files          45       47       +2     
  Lines       17065    17216     +151     
==========================================
+ Hits         4937     5028      +91     
- Misses      12128    12188      +60
Files Changed Coverage Δ
osc/commandline.py 19.03% <6.25%> (+0.03%) ⬆️
osc/build.py 6.47% <23.07%> (-0.01%) ⬇️
osc/git_scm/__init__.py 75.00% <75.00%> (ø)
osc/git_scm/store.py 75.89% <75.89%> (ø)
osc/store.py 84.23% <83.33%> (-0.05%) ⬇️
osc/core.py 35.32% <100.00%> (-0.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 27, 2023
View reviewed changes
osc/core.py
@@ -49,6 +49,7 @@
from . import conf
from . import meter
from . import oscerr
from . import store as osc_store

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
osc.store
Loading
begins an import cycle.
osc/git_scm/store.py Fixed Show fixed Hide fixed
tests/test_git_scm_store.py
def tearDown(self):
try:
shutil.rmtree(self.tmpdir)
except OSError:

Check notice

Code scanning / CodeQL

Empty except Note test

'except' clause does nothing but pass and there is no explanatory comment.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 28, 2023
View reviewed changes
osc/git_scm/store.py
def _unset_option(self, name):
try:
self._run_git(["config", "--local", "--unset", f"osc.{name}"])
except subprocess.CalledProcessError:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
@dmach dmach marked this pull request as ready for review July 31, 2023 06:29
@dmach
Copy link
Contributor Author

dmach commented Jul 31, 2023

The new code integrates nicely, no massive hacks in the existing code.
The only big unresolved thing is hard-coded project that is determined from branch name. We'll fix it once we have the information available in git, gitea, obs or any other place.

@dmach dmach merged commit aae2024 into openSUSE:master Jul 31, 2023
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support building from dist-git
1 participant
@dmach