Use blake3 for comparing files #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use hashing only to figure out if two files are the same then blake3 is very fast and prefered over sha2 https://github.com/BLAKE3-team/BLAKE3
|
Looking at the CI it seems blake3 has slightly sped it up: So most of the time is being used in other parts of the program. But still worth it especially when no one has shown a major attack against this hashing algorithm in the years since it was first published in 2021. @uncomfyhalomacro and @Firstyear for thoughts |
|
Seems fine to me :) |
Firstyear
approved these changes
Nov 7, 2024
|
wooops. i just updated and pushed and didn't see this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use hashing only to figure out if two files are the same then blake3 is very fast and preferred over sha2.
See: https://github.com/BLAKE3-team/BLAKE3