MIDI Controller Binding window UX improvement #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… labels above the controls. Clicking the link button when no link is set asks the user to set it.
…untitled for no named controllers - more work needed here
…h a 'made by' message
…Hide author button when no author given.
|
After some more testing. I found a regression here where binds are not truly removed. I will post again when fixed |
…emove it. replaced callback with a lambda function
|
Seems to be fixed now |
|
Another bug found in this. When removing a bind, the save function forgets the name of the file. Will post again when fixed. |
…oduces too many headaches so I have disallowed blank input for midi controller name
|
The screenshots & improvements look really good - nice work. I'll try find some time soon-ish (..) to review, but I'm not finding a lot of time for OpenAV stuff recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the UX of creating midi bindings.
In the settings drop down it is no longer called "Options" it is now called "MIDI Options" some light refactoring was done to reflect this in the code also.
Key changes include rearranging UI elements, adding zebra striping for better readability, and a more friendly way for a new user to interact with it.
The author and link buttons have been merged into one that only appears if there is an author to credit and will only open the browser if a link is set.
A new button called "Export Bindings" has been added to ask the user both their Author name and their URL. Since there is no repository where users can get other bindings from each other I don't see the need to have these element front and center. What users want from this screen is to set up their midi bindings.
Moved the targeting buttons to the top and with a brief explanation of how the program expects you to work with it.
The index numbers that could get out of order quickly are no longer shown to the user and instead are replaced by a red X to remove a specific bind.
A lot of buttons in these screens have been renamed for better clarity of their function.
I can see many more improvements to this screen for example the "pretty names" that LUPPP presents are not that pretty and adding ways to debug your midi device to see what events are being sent (if any). I spent a lot more time on this than expected so I may go back and do these other improvements later.
Please let me know if some of the text here does not make sense or could be phrased better or any other improvements you have
Here are some screenshots showing before and after of each screen.
Before:
After:
Before:
After:
Before:
After:
