Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export max and min in Metric exporter for HistogramDataPoint #601

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Export max and min in Metric exporter for HistogramDataPoint #601

merged 1 commit into from
Sep 12, 2024

Conversation

nachoBonafonte
Copy link
Member

Fixes #594

vvydier
vvydier approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@vvydier vvydier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was only missing in Histogram case, already in ExponentialHistogram. looks good.

@nachoBonafonte nachoBonafonte merged commit 3093351 into open-telemetry:main Sep 12, 2024
6 checks passed
@nachoBonafonte nachoBonafonte deleted the add-min-max-to-otlp-metric-exporter branch September 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvydier vvydier vvydier approved these changes

@bryce-b bryce-b Awaiting requested review from bryce-b bryce-b is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exported metric data has a count and sum but no min and max value
2 participants
@nachoBonafonte @vvydier