-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes OpenTelemetryConcurrency target #592
Exposes OpenTelemetryConcurrency target #592
Conversation
Hmm, kinda strange that the Linux CI appears to be stuck. I'm able to successfully run these tests on a swift:5.10 docker image locally. Any ideas? |
It may just be an intermittent failure, I had quite a few when working on the original PR. There were also a couple of issues with tests never finishing on Linux even when they worked fine on other platforms. I fixed those issues that I encountered but it's possible another one has popped up now. |
Hi @NeedleInAJayStack the concurrency target should be its own product. Adding it to the OpenTelemetryApi product would create a circular dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it a separate product
ce93f21
to
25057d3
Compare
Sure, I've adjusted it to be a separate product. Thanks! |
@nachoBonafonte Just a gentle reminder on this PR - any thoughts on my changes? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder, looks good to me now.
* main: Exposes OpenTelemetryConcurrency target (open-telemetry#592) # Conflicts: # [email protected]
Thank you @semicoleon for the excellent changes in #546! This MR simply exposes the new
OpenTelemetryConcurrency
target through theOpenTelemetryApi
product so that it is available for usage by downstream packages. This enables usage as shown in/Examples/ConcurrencyContext/main.swift
.If you'd prefer for
OpenTelemetryConcurrency
to get its own product, just let me know and I'm happy to adjust. Thanks!