Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds StdoutLogExporter to match (renamed) StdoutSpanExporter #559

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Adds StdoutLogExporter to match (renamed) StdoutSpanExporter #559

merged 3 commits into from
Jul 23, 2024

Conversation

atreat
Copy link
Contributor

@atreat atreat commented Jul 22, 2024

  • Adds LogExporter to help debug Logging. Will output to stdout similar to the Span exporter.
  • Renames StdoutExporter to StdoutSpanExporter to make room for StdoutLogExporter
  • Adds typealias for StdoutExporter to not break callers usage
    • Adds deprecation notice to typealias to alert callers that name has changed.

@atreat
Copy link
Contributor Author

atreat commented Jul 22, 2024

Let me know if I should update the Logs Sample to include an example of this LogRecordExporter

vvydier
vvydier approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@vvydier vvydier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example with the renamed log API will be helpful

@bryce-b
Copy link
Member

bryce-b commented Jul 23, 2024

@atreat can you rebase this PR? (the auto merge isn't working)

@atreat atreat force-pushed the atreat/add-stdout-log-exporter branch from 7d2d1c8 to 344cda6 Compare July 23, 2024 17:46
@bryce-b bryce-b merged commit 3f7c9a1 into open-telemetry:main Jul 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvydier vvydier vvydier approved these changes

@nachoBonafonte nachoBonafonte nachoBonafonte approved these changes

@bryce-b bryce-b Awaiting requested review from bryce-b bryce-b is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atreat @bryce-b @vvydier @nachoBonafonte