-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server attributes to Vertex AI spans #3208
base: main
Are you sure you want to change the base?
Conversation
5e4ff27
to
152fb20
Compare
|
||
return { | ||
server_attributes.SERVER_ADDRESS: parsed.hostname, | ||
server_attributes.SERVER_PORT: parsed.port or 443, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
consider using 443 as a default (unless Vertex has grpc endpoint and uses a different port by default). If virtually all vertex spans would have port 443, let's just default to it and reduce telemetry volume a bit.
We have this clause for azure ai
server.port | int | GenAI server port. [5] | 80; 8080; 443 | Conditionally Required If server.address is set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If virtually all vertex spans would have port 443
Yes that's the case, and the suggestion makes sense to me. But isn't this special case for azure making server.port
incompatible with the "parent type" GenAI span?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add a note there that system-specific conventions can provide a default value. We can also add a small doc for vertex ai and mention default port there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor suggestion to not populate port if it's 443, but LGTM
Description
Add
server.address
andserver.port
semconv attributes to Gen AI spans.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.