Skip to content

Commit

Permalink
Use lychee new cache-exclude-status option and upgrade lychee-action (#…
Browse files Browse the repository at this point in the history
…6323)

Lychee's `cache-exclude-status` option has shipped. So we can use it
rather than ignore 429s.
This also upgrades lychee-action to 2.1.0. We had to revert that in
#6229 due
to a regression, which was fixed in
lycheeverse/lychee-action#255
  • Loading branch information
dmathieu authored Nov 14, 2024
1 parent 5b9cf72 commit 315b0af
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/links-fail-fast.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@ jobs:
restore-keys: cache-lychee-

- name: Link Checker
uses: lycheeverse/lychee-action@v1.10.0
uses: lycheeverse/lychee-action@v2.1.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
fail: true
# TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved
args: --max-concurrency 5 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 .
args: --max-concurrency 5 --cache --max-cache-age 1d --cache-exclude-status 300..=599 .
5 changes: 2 additions & 3 deletions .github/workflows/links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,11 @@ jobs:

- name: Link Checker
id: lychee
uses: lycheeverse/lychee-action@v1.10.0
uses: lycheeverse/lychee-action@v2.1.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
# TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved
args: --max-concurrency 1 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 .
args: --max-concurrency 1 --cache --max-cache-age 1d --cache-exclude-status 300..=599 .

- name: Create Issue From File
if: steps.lychee.outputs.exit_code != 0
Expand Down

0 comments on commit 315b0af

Please sign in to comment.