[processor/deltatocumulative] - Fix tests on windows #35902
+63
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's an awkward timing right now cause I'm stuck between airports for a few days 😅. Could somebody add the necessary label to activate the windows tests? |
songy23
added
Run Windows
|
Urgh, kinda sucks to debug this without a windows machine. I'm almost sure we're failing here @sh0rez |
ArthurSens
force-pushed
the
deltatocumulative-windowsbug
branch
from
c87b5b3
to
87ae566
Compare
Our test format testar is based on golang.org/x/tools/txtar, which does not properly handle CRLF line endings. When using git on windows, git turns LF into CRLF, making our tests fail on that platform. The Go CL does not appears to be inactive, so I opted for replacing CRLF with LF for now within testar.
ArthurSens
force-pushed
the
deltatocumulative-windowsbug
branch
from
87ae566
to
637032c
Compare
ArthurSens
changed the title
songy23
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our test format testar is based on golang.org/x/tools/txtar, which does
not properly handle CRLF line endings.
When using git on windows, git turns LF into CRLF, making our tests fail
on that platform.
The Go CL does not appears to be inactive, so I opted for replacing CRLF
with LF for now within testar.
Link to tracking issue
Fixes #35876