Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Fix - Operators with DropOnErrorQuiet should drop log en… #35834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamerJ
Copy link
Contributor

@SamerJ SamerJ commented Oct 16, 2024

Description

Fixed issue in which Operators with DropOnErrorQuiet are not dropping log entries on error.

Note: This issue was introduced by a bug fix meant to ensure Silent Operators are not logging errors (#35010). With this fix,
this side effect bug has been resolved.

Link to tracking issue

Fixes 35010

Testing

Added UT

@SamerJ SamerJ requested review from djaglowski and a team as code owners October 16, 2024 14:52
Copy link

linux-foundation-easycla bot commented Oct 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@SamerJ SamerJ force-pushed the fix/parser/error-propagation branch 3 times, most recently from 5bb0df7 to d0e2b3f Compare October 17, 2024 14:25
@SamerJ SamerJ force-pushed the fix/parser/error-propagation branch from d0e2b3f to bbc8a76 Compare October 23, 2024 09:56
@SamerJ
Copy link
Contributor Author

SamerJ commented Oct 23, 2024

@fatsheep9146
Let me know why you think.
Also, should there be any questions, let me know 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants