Add ability to enable debug logging for disk buffering #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
commented
Jan 16, 2025
core/src/main/java/io/opentelemetry/android/features/diskbuffering/DiskBufferingConfig.kt
Show resolved
Hide resolved
marandaneto
reviewed
Jan 17, 2025
Comment on lines
20
to
22
| val maxFileAgeForWriteMillis: Long = TimeUnit.SECONDS.toMillis(30), | ||
| val minFileAgeForReadMillis: Long = TimeUnit.SECONDS.toMillis(33), | ||
| val maxFileAgeForReadMillis: Long = TimeUnit.HOURS.toMillis(18), |
There was a problem hiding this comment.
should they be const as well? (30, 33, 18)?
marandaneto
reviewed
Jan 17, 2025
| ): DiskBufferingConfig { | ||
| var minRead = minFileAgeForReadMillis | ||
| if (minFileAgeForReadMillis <= maxFileAgeForWriteMillis) { | ||
| minRead = maxFileAgeForWriteMillis + 5 |
There was a problem hiding this comment.
nasty :D but yeah its there in the Java file already
marandaneto
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #664 (which seems to be stalled out).
Resolves #597.
This PR adds a debugEnabled flag to the disk buffering config and converts the config to kotlin.