Restrict tar transform to regular files

[madscientist159]

Without this restriction, symlinks are rewritten and corrupted.

Example without the restriction:

Input tree (valid):
package-githash/file1
package-githash/link -> ./file1

Output tree (broken):
package-githash/file1
package-githash/link -> package-githash/file1

[sammj]

Is this something that should go upstream as well?

[madscientist159]

Yes, that is the intent of the pull request.

[sammj]

I meant actual upstream Buildroot :) This looks sane but it would be good to be able to reference it going to Buildroot's development list (ie. http://lists.buildroot.org/mailman/listinfo/buildroot) as well.

[madscientist159]

@sammj Sorry, didn't quite understand there at first 😄 I went ahead and sent it upstream as well.

[shenki]

Thank you for the patch.

I see that upstream asked you to use a different flag. Let me know when you've sent your v3, and I will apply that to our buildroot fork. If you cc me ([email protected]) I can review it too.

[madscientist159]

Yes, the new flag is verified to work, v3 wasn't set yet since I need to figure out what the formatting problem is when sending the patches in.

[mdmillerii]

I need to figure out what the formatting problem is when sending the patches in.

@madscientist159 you need to place a blank line in the commit message after the subject before the body

Otherwise git will concatnate the lines then decide the subject is too long and you end up with your broken formatting.