Skip to content

Commit

Permalink
build: bump github.com/golang/glob, remove replace directive (#7056)
Browse files Browse the repository at this point in the history
Just recently, glog introduced a fix for the potentially very expensive network
call on windows that had been troubling us before:

golang/glog@9730314

It's become the v1.2.2 release.

The release is now in vendor, and the replacement has been removed.

Fixes #7024.

Signed-off-by: Stephan Renatus <[email protected]>
  • Loading branch information
srenatus authored Sep 24, 2024
1 parent 2c56293 commit 55aa75d
Show file tree
Hide file tree
Showing 18 changed files with 2,540 additions and 47 deletions.
21 changes: 0 additions & 21 deletions build/replacements/github.com/golang/glog/glog.go

This file was deleted.

3 changes: 0 additions & 3 deletions build/replacements/github.com/golang/glog/go.mod

This file was deleted.

5 changes: 0 additions & 5 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,6 @@ require (
gopkg.in/ini.v1 v1.67.0 // indirect
)

// glog is only used through badger, and only for fatal log-and-exit. However, it comes
// at a cost, its init function will lookup the current user, and on Windows, that's much
// work.
replace github.com/golang/glog => ./build/replacements/github.com/golang/glog

// retract directive comment below will be displayed as a warning on pkg.go.dev for the old package name. Please retain
// this for future releases.

Expand Down
3 changes: 3 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ github.com/gobwas/glob v0.2.3 h1:A4xDbljILXROh+kObIiy5kIaPYD8e96x1tgBhUI5J+Y=
github.com/gobwas/glob v0.2.3/go.mod h1:d3Ez4x06l9bZtSvzIay5+Yzi0fmZzPgnTbPcKjJAkT8=
github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=
github.com/golang/glog v1.2.2 h1:1+mZ9upx1Dh6FmUTFR1naJ77miKiXgALjWOZ3NVFPmY=
github.com/golang/glog v1.2.2/go.mod h1:6AhwSGph0fcJtXVM/PEHPqZlFeoLxhs7/t5UDAwmO+w=
github.com/golang/groupcache v0.0.0-20190702054246-869f871628b6/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da h1:oI5xCqsCo564l8iNU+DwB5epxmsaqB+rhGL0m5jtYqE=
Expand Down
191 changes: 191 additions & 0 deletions vendor/github.com/golang/glog/LICENSE

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions vendor/github.com/golang/glog/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 55aa75d

Please sign in to comment.