feat: remove cel driver from framework #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avinash Patnala <[email protected]>
|
LGTM, pending approval of the Gatekeeper PR (modulo import override) so that the code moved to G8r can be merged as a fast-follow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 54.68% 53.42% -1.26%
==========================================
Files 71 97 +26
Lines 5241 6115 +874
==========================================
+ Hits 2866 3267 +401
- Misses 2073 2513 +440
- Partials 302 335 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
approved these changes
Oct 30, 2024
|
Waiting on open-policy-agent/gatekeeper#3570 approval to merge |
|
@maxsmythe does this PR LGTY? we need this PR to merge first so go.mod in open-policy-agent/gatekeeper#3570 can point to the latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.