Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tune jsonnet VM stack trace logging and add test coverage #1037

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: tune jsonnet VM stack trace logging and add test coverage #1037

wants to merge 2 commits into from

Conversation

thevilledev
Copy link
Contributor

@thevilledev thevilledev commented Jan 15, 2025 •
edited
Loading

  • Set MaxStackTraceSize to 20 for cleaner errors
  • Add test for stack overflow prevention
  • Improve test structure with table-driven pattern

@thevilledev
fix: set jsonnet VM stack limits and add test coverage
7428841 
- Set MaxStack to 500 frames to prevent deep recursion
- Set MaxStackTraceSize to 20 for cleaner errors
- Add test for stack overflow prevention
- Improve test structure with table-driven pattern

Signed-off-by: Ville Vesilehto <[email protected]>
@thevilledev thevilledev force-pushed the fix/recursive-jsonnet branch from 2dd2adf to 7428841 Compare January 16, 2025 08:18
boranx
boranx reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@boranx boranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems jsonnet.MakeVM() returns these values by default, do you think we'd still need to fine-tune it?

@thevilledev thevilledev changed the title fix: set jsonnet VM stack limits and add test coverage fix: tune jsonnet VM stack trace logging and add test coverage Jan 23, 2025
@thevilledev
Copy link
Contributor Author

Thanks, totally missed that. I removed it from the PR but kept the other changes. Also updated the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boranx boranx boranx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thevilledev @boranx