[WIP DNM] levelzero: use zesInit() when available #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When zesInit() is available (starting in specs 1.5), we don't need all the stuff to set ZES_ENABLE_SYSMAN=1 in the environment anymore. This assumes that zesInit() works for real, which was not the case in first compute-runtime releases (it returned "unsupported"). Those releases won't be supported anymore because they'd need a runtime-check at configure time to find out that the ZES_ENABLE_SYSMAN=1 stuff must be enabled. Only use a compile-check to switch between zesInit() and ZES_ENABLE_SYSMAN=1, and tell users to avoid those L0 runtime versions where zesInit() fails. Signed-off-by: Brice Goglin <[email protected]>
|
@bgoglin zesInit () is fully supported avaliable , can you start using zesInit() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge until a compute-runtime release supports zesInit(). Blacklist the releases with unsupported zesInit() in the error messages before merging this PR.
Refs #687
TODO just drop releases without zesInit() and abort if the backend if zesInit() fails
TODO check whether zesInit() must be called in a constructor before any other zeInit() or just in the hwloc backend as usual.
TODO requires oneapi-src/level-zero#153