Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMSIG]支持 DeblurGANv2 inference #1955

Merged
merged 52 commits into from
Aug 8, 2023
Merged

[MMSIG]支持 DeblurGANv2 inference #1955

merged 52 commits into from
Aug 8, 2023

Conversation

xiaomile
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

demo 示例
python mmagic\demo\mmagic_inference_demo.py --model-name deblurganv2 --model-comfig ../configs/deblurganv2/deblurganv2_fpn_inception.py --model-ckpt 权重文件路径 --img 测试图片路径 --device cpu --result-out-dir ./out.png
@mm-assistant
Copy link

mm-assistant bot commented Jul 24, 2023

We recommend using English or English & Chinese for pull requests so that we could have broader discussion.

@xiaomile xiaomile changed the title 支持 DeblurGANv2 inference [MMSIG]支持 DeblurGANv2 inference Jul 24, 2023
@zengyh1900
Copy link
Collaborator

hi @xiaomile ,
thank you for your contribution! Before I start the review, you need to complete several steps,

  1. provide unitest
  2. provide README.md
  3. fix CI test

update model-index
CI test fix and update readme.md
fix CI test and update readme.md
代码调整,参数名保持一致
doc string coverage
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 42.70% and project coverage change: -1.37% ⚠️

Comparison is base (c68fdb8) 82.24% compared to head (2d5d2e1) 80.87%.
Report is 3 commits behind head on main.

❗ Current head 2d5d2e1 differs from pull request most recent head f21e10f. Consider uploading reports for the commit f21e10f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1955      +/-   ##
==========================================
- Coverage   82.24%   80.87%   -1.37%     
==========================================
  Files         416      423       +7     
  Lines       27955    28952     +997     
  Branches     4372     4461      +89     
==========================================
+ Hits        22992    23416     +424     
- Misses       4025     4579     +554     
- Partials      938      957      +19     
Flag Coverage Δ
unittests 80.87% <42.70%> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mmagic/apis/mmagic_inferencer.py 84.61% <ø> (ø)
mmagic/models/losses/gan_loss.py 81.86% <0.00%> (-0.86%) ⬇️
mmagic/datasets/transforms/albu_function.py 25.86% <25.86%> (ø)
mmagic/models/losses/adv_loss.py 35.77% <35.77%> (ø)
...gic/models/editors/deblurganv2/deblurganv2_util.py 36.99% <36.99%> (ø)
...odels/editors/deblurganv2/deblurganv2_generator.py 42.54% <42.54%> (ø)
...s/editors/deblurganv2/deblurganv2_discriminator.py 46.08% <46.08%> (ø)
mmagic/datasets/mscoco_dataset.py 85.00% <62.50%> (-6.43%) ⬇️
mmagic/models/editors/deblurganv2/deblurganv2.py 64.51% <64.51%> (ø)
mmagic/datasets/transforms/__init__.py 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaomile
Copy link
Contributor Author

xiaomile commented Jul 28, 2023

hi @zengyh1900 ,

  • provide unitest
  • provide README.md
  • fix CI test

these steps were completed

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
configs/deblurganv2/deblurganv2_fpn_inception.py Outdated Show resolved Hide resolved
configs/deblurganv2/deblurganv2_fpn_mobilenet.py Outdated Show resolved Hide resolved
mmagic/models/editors/deblurganv2/deblurganv2.py Outdated Show resolved Hide resolved
configs/deblurganv2/README.md Show resolved Hide resolved
zengyh1900 and others added 14 commits July 28, 2023 16:46
Co-authored-by: Yanhong Zeng <[email protected]>
Co-authored-by: Yanhong Zeng <[email protected]>
Co-authored-by: Yanhong Zeng <[email protected]>
Co-authored-by: Yanhong Zeng <[email protected]>
Co-authored-by: Yanhong Zeng <[email protected]>
Co-authored-by: Yanhong Zeng <[email protected]>
Co-authored-by: Yanhong Zeng <[email protected]>
move the implementation of loss function to mmagic/models/losses
add quick start to readme
@xiaomile
Copy link
Contributor Author

xiaomile commented Aug 3, 2023

hi @zengyh1900 ,requested changes were completed.

configs/deblurganv2/README.md Show resolved Hide resolved
mmagic/models/editors/deblurganv2/deblurganv2_util.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaomile It is not easy work, but you have achieved it! Thanks for your great contribution!

@zengyh1900 zengyh1900 merged commit 06f8b4b into open-mmlab:main Aug 8, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants