Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Add PR deployment action #313

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

teodutu
Copy link
Member

@teodutu teodutu commented Jul 10, 2023

The action builds the rendered website and pushes it to the gh-pages in a directory named after the PR number: refs/pull/<number>/merge. It then publishes a message containing the link where the website may be inspected.

I tested the action here: teodutu#8 (comment)

@teodutu teodutu added the WIP work in progress label Jul 10, 2023
@teodutu teodutu self-assigned this Jul 10, 2023
@github-actions github-actions bot added area/infra Update to infrastructure / scripts kind/new New content / item labels Jul 10, 2023
@teodutu teodutu force-pushed the pr-deployment branch 6 times, most recently from a2a2b80 to d162b48 Compare July 11, 2023 06:05
@gabrielmocanu
Copy link
Contributor

Any way to test it?

.github/workflows/pr-deployment.yml Outdated Show resolved Hide resolved
.github/workflows/pr-deployment.yml Show resolved Hide resolved
.github/workflows/pr-deployment.yml Outdated Show resolved Hide resolved
@teodutu
Copy link
Member Author

teodutu commented Jul 14, 2023

Any way to test it?

Yes, the PR itself. The action fails unfortunately.

@teodutu
Copy link
Member Author

teodutu commented Jul 14, 2023

I've made the changes you requested @gabrielmocanu. Let me know if you find a way to fix it.

@teodutu teodutu force-pushed the pr-deployment branch 5 times, most recently from b334f52 to 014ea92 Compare September 28, 2023 17:09
@razvand
Copy link
Contributor

razvand commented Oct 1, 2023

@teodutu , is this still relevant? Should we use the workflows in the actions repository?

@teodutu
Copy link
Member Author

teodutu commented Oct 1, 2023

Yes, it is relevant. We don't have such a workflow in the actions repo. It would be great if we did, but it's easier to validate it here. So I wish to get this working together with @VladNastase and whoever else may help and then move it to the actions repo to be used globally.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teodutu , this looks good to me. Let's wait for @gabrielmocanu 's opinion and merge this as fast as possible.

@gabrielmocanu gabrielmocanu force-pushed the pr-deployment branch 3 times, most recently from d581073 to d29e783 Compare October 3, 2023 13:28
@gabrielmocanu gabrielmocanu requested review from gabrielmocanu and removed request for gabrielmocanu October 3, 2023 13:28
The action builds the rendered website and pushes it to the branch
`gh-pages` in a directory named after the PR number.
It then publishes a message containing the link where the website
may be inspected.
In order to trigger the workflow, label `needs-rendering` on the PR
it's required.

Signed-off-by: Teodor Dutu <[email protected]>
Signed-off-by: Gabriel Mocanu <[email protected]>
@gabrielmocanu
Copy link
Contributor

@teodutu teodutu merged commit 55852bc into open-education-hub:main Oct 3, 2023
2 of 3 checks passed
@teodutu teodutu deleted the pr-deployment branch October 3, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Update to infrastructure / scripts kind/new New content / item WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants