-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify pull request usage in README #494
Clarify pull request usage in README #494
Conversation
@tavaresrodrigo Thanks for the PR! For the DCO signoff, since there's only one commit you can run these commands to add the signoff: git commit --amend --signoff --no-edit
git push --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I think the wording looks good--just needs some linting and it'll be good to go!
b5a11ff
to
c9b2ad7
Compare
2343c10
to
da5bb79
Compare
We prefer to minimize the number of commits--would you please squash these commits into a single commit? (Let me know if any guidance is needed on squashing.) After that, it should be good to merge. |
Signed-off-by: Rodrigo Tavares <[email protected]> Update README.md Thanks @dhaiducek Co-authored-by: Dale Haiducek <[email protected]> Signed-off-by: Rodrigo Tavares <[email protected]>
da5bb79
to
897d8cf
Compare
Thanks for the helpful guidance @dhaiducek ! I have squashed all commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @tavaresrodrigo!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, tavaresrodrigo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2b06406
into
open-cluster-management-io:main
This pull request addresses an issue in the policy-collection README where the usage of pull requests may be confusing.
The current text suggests using a pull request to pull changes, which is not accurate. A pull request should be used to propose merging changes.
Changes Made:
This change ensures that the instructions are clear and technically accurate, helping users understand the correct use of pull requests.
Signed-off-by: Rodrigo Tavares [email protected]