Remove PlacementRule and PlacementBinding resources from the policy-collection #488
Conversation
policygenerator/policy-sets/community/zts-xcrypt/policy-zts-xcrypt-version-1.yaml
Outdated
Show resolved
Hide resolved
yiraeChristineKim
force-pushed
the
ACM-9081
branch
from
bb19b66 to
05221ae
Compare
There was a problem hiding this comment.
Deleting this file should have broken the automated policy validation script. It didn't break obviously because the contributed policyset doesn't seem to have a kustomization.yaml file. I think this change should be removed, but we at least shouldn't be causing additional problems to an already broken policyset.
yiraeChristineKim
force-pushed
the
ACM-9081
branch
3 times, most recently
from
cb30f45 to
440289a
Compare
Signed-off-by: yiraeChristineKim <[email protected]>
Signed-off-by: yiraeChristineKim <[email protected]>
yiraeChristineKim
force-pushed
the
ACM-9081
branch
from
440289a to
877f1b0
Compare
README.md
Outdated
| The policies are applied to all managed clusters that are available, and have the `environment` set | ||
| to `dev`. If policies need to be applied to another set of clusters, update the | ||
| `PlacementRule.spec.clusterSelector.matchExpressions` section in the policies. | ||
|
|
||
| **Note**: As new clusters are added that fit the criteria previously mentioned, the policies are |
There was a problem hiding this comment.
The Note here should either be deleted or moved.
README.md
Outdated
| **Note**: As new clusters are added that fit the criteria previously mentioned, the policies are | ||
| applied automatically. | ||
|
|
||
| **Important**: The `PlacementRule` resource has been deprecated so policy users must begin moving to |
There was a problem hiding this comment.
Can you more this note towards the top of the file? I think we want to make this really visible for a while. Not sure how to make it even more noticeable for users.
There was a problem hiding this comment.
how about current change
…Ops section. Update the README to reflect the deletion of PlacementRule in the GitOps section and readme. Signed-off-by: yiraeChristineKim <[email protected]>
yiraeChristineKim
force-pushed
the
ACM-9081
branch
from
877f1b0 to
afbca7f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f8d8dc9
into
open-cluster-management-io:main
Ref: https://issues.redhat.com/browse/ACM-9081