delete restore when policy is disabled #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentina Birsan <[email protected]>
|
/cc @dhaiducek |
dhaiducek
approved these changes
Jun 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: birsanv, dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1644712
into
open-cluster-management-io:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ACM-12080
Since the oadp install namespace cannot be deleted due to the restore resource finalizer, prune any restore resource created by the policy, when the policy is disabled; using the
pruneObjectBehavior: DeleteIfCreatedStill going to delete the namespace because the OADP ClusterServiceVersion is not created by the policy so it cannot be removed by the policy using the
pruneObjectBehavior: DeleteIfCreatedoptionChanges:
pruneObjectBehavior: DeleteIfCreatedoption to the Restore creation template; this will allow the ns to be deletedpruneObjectBehavior: DeleteIfCreatedoption to the Namespace creation template; this will clean up the OADP CSV