-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoimport policy to include MultiClusterEngineHCP #478
Add autoimport policy to include MultiClusterEngineHCP #478
Conversation
community/CM-Configuration-Management/policy-mce-hcp-autoimport.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your policy looks good. I see your commit is still trying to change the ROSA policy too, I think those changes are just reflecting the already delivered changes, but wondering if you can remove that file from the commit.
I made some changes to the ROSA policy as well like the condition type wasn't correct here and removing the global remediation here The other changes I guess github missing around. |
@@ -12,18 +12,15 @@ metadata: | |||
will happen. If you do not want all of your ROSA clusters to be automatically | |||
imported, you can configure filters or add an annotation. | |||
spec: | |||
remediationAction: inform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By convention we want to make policies inform by default. This way the customer has an opportunity to see what resources the policy will apply to before enforcing. For this policy I think the inform is useful so the customer can determine if they want to use a filter to target specific Discovered clusters or if they are ok with all that are matched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, it's just confused me as the configuration-policy "policy-rosa-managedcluster-status" is inform and the reset are enforce. okay, I will put it back.
…o import policy Signed-off-by: melserngawy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good and appreciate the fix too!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, serngawy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e3692c7
into
open-cluster-management-io:main
This policy to allow auto import clusters with type MultiClusterEngineHCP from discovered clusters