Create a policy to automatically import discovered ROSA clusters #470
Conversation
gparvin
force-pushed
the
rosa-autoimport
branch
from
399ee9f to
ca34adf
Compare
gparvin
changed the title
|
I added the filtering for the annotation that indicates when an import has already been attempted and therefore should now be skipped. |
| name: discovery-config | ||
| namespace: open-cluster-management-global-set | ||
| data: | ||
| rosa-filter: "bennett" |
There was a problem hiding this comment.
That was part of a demo -- thanks for catching that.
| status: | ||
| conditions: | ||
| - type: ManagedClusterAvailable | ||
| status: "True" |
There was a problem hiding this comment.
Rather than skip if discovery.open-cluster-management.io/previously-auto-imported is set, it might be cool to just make the clusterset annotation conditional on this so that the policy can still report on the status after it's been imported but still allow the user to change the clusterset.
There was a problem hiding this comment.
The ManagedCluster resource won't exist, it will have been deleted after being detached.
This policy monitors DiscoveredCluster resources for ROSA clusters and configures matching discovered clusters to be automatically imported. Status is shown for any that have been configured to be automatically imported. Filtering by the discovered cluster display name can be updated in the policy by editing the ConfigMap. Refs: - https://issues.redhat.com/browse/ACM-10304 Signed-off-by: Gus Parvin <[email protected]>
gparvin
force-pushed
the
rosa-autoimport
branch
from
ca34adf to
572453a
Compare
|
The related jira work item: https://issues.redhat.com/browse/ACM-11385 |
|
Putting a hold to get this approved now, but will keep it in progress until we get closer to releasing the implementation used by the policy. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit f3de3d9
into
open-cluster-management-io:main
This policy monitors DiscoveredCluster resources for ROSA clusters and configures matching discovered clusters to be automatically imported. Status is shown for any that have been configured to be automatically imported. Filtering by the discovered cluster display name can be updated in the policy by editing the ConfigMap.
Refs: