-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add printer supporting tree, table and yaml format #174
feat: add printer supporting tree, table and yaml format #174
Conversation
#133 |
/hold |
@ycyaoxdu Can't you use something like this: clusteradm/pkg/cmd/get/cluster/exec.go Line 54 in cae3fa5
|
f50b50f
to
6c87d4d
Compare
I don't think a genericoption is the good choice as I think |
hi @itdove I've noticed that we need to add apis to generalize the --output ? could you please help to contribute this feature? or give me some advice on this? thanks a lot. |
4336c6d
to
add786c
Compare
@qiujian16 PTAL
default format has set to tree. |
/assign @qiujian16 |
fec3728
to
8fdf005
Compare
a53c51a
to
1d4e300
Compare
Signed-off-by: ycyaoxdu <[email protected]>
Signed-off-by: ycyaoxdu <[email protected]>
1d4e300
to
f714199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ycyaoxdu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Signed-off-by: ycyaoxdu [email protected]