Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The columns marked ignored were NOT ignored on update. #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

The columns marked ignored were NOT ignored on update. #41

wants to merge 1 commit into from

Conversation

hirayama-onagigawa-computing
Copy link
Contributor

The columns to be set as ignored with $form->ignore('foo');, is NOT ignored on update.

This revives laravel-admin's code to skip ignored column.

@open-admin-org
Copy link
Owner

Hi @hirayama-onagigawa-computing
Thanks for committing this fix, it did some tests, and the values seems to be ignore. When i set a field to ignore
Do you maybe have a more detailed use case where this go wrong?

@hirayama-onagigawa-computing
Copy link
Contributor Author

@open-admin-org
OK, I'll try to make a small sample. Please wait 'til done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anizourida anizourida anizourida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hirayama-onagigawa-computing @open-admin-org @anizourida