make install script use https instead of git protocol #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Me and other people have firewall restrictions which causes this script to fail when running git clone commands that use the git protocol. I suggest instead that we use https. Technically, it will also verify that you got the repository code from the correct server as well. See this link for details: https://gist.github.com/grawity/4392747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me and other people have firewall restrictions which causes this script to fail when running git clone commands that use the git protocol. I suggest instead that we use https. Technically, it will also verify that you got the repository code from the correct server as well. See this link for details: https://gist.github.com/grawity/4392747