Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Answer Rework + Agentic flow (Langgraph Introduction) #3652

Closed
wants to merge 91 commits into from
Closed

Answer Rework + Agentic flow (Langgraph Introduction) #3652

wants to merge 91 commits into from

Conversation

evan-danswer
Copy link
Contributor

Description

New Langgraph Agent flow + Answer class rework. Broadly speaking:

  • Rudimentary way to call the agentic flow from the frontend
  • Standard flow embedded in Langgraph

There are some known issues at the moment:

  • We don't yet have an integrated way to do citation processing and tool calling. These will follow over the next few days.
  • There's a recurring logger error about a file not existing and attempting to be deleted
  • naming and file structure is inconsistent in some places
  • Not nearly enough testing has been done

How Has This Been Tested?

Happy path tested manually, needs many more tests of edge cases and some added unit/integration tests.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

joachim-danswer and others added 30 commits December 16, 2024 11:23
@joachim-danswer
initial onyx changes
6311b70
@hagen-danswer
fix: update staged changes
11ce2a6
@hagen-danswer
fixed key issue
82914ad
@hagen-danswer
brough over joachim changes
ff03d71
@hagen-danswer
Now using result objects
1f88b60
@hagen-danswer
fixed expanded retrieval subgraph
2f2b9a8
@hagen-danswer
got answer subgraph working
442c947
@hagen-danswer
Cleanup
d66180f
@hagen-danswer
main graph works
e76cbec
@hagen-danswer
query->question
fd694be
@hagen-danswer
mypy fixed
8399d2e
@hagen-danswer
naming and comments
50a216f
@hagen-danswer
explicitly ingest state from retrieval
9d3220f
@hagen-danswer
renames
0c75ca0
@hagen-danswer
figured it out
bca02eb
@hagen-danswer
made query expansion explicit
2d6f746
@hagen-danswer
seperate edge for initial retrieval
ffc81f6
@hagen-danswer
Merge pull request #3505 from onyx-dot-app/fix-the-states
c759fb5 
Fix the states
@hagen-danswer
renamed PrimaryState to CoreState
cebe237
@hagen-danswer
added chunk_ids and stats to QueryResult
34aa054
@joachim-danswer
initial_test_flow
2a3328f
@joachim-danswer
regression-test graph vs regulat graph
f4c826c
@joachim-danswer
improvements
fa48101
@joachim-danswer
initial mypy changes
ca3f3be
@joachim-danswer
core mypy resolutions
c4af11c
@joachim-danswer
tmp_state_model_sep
2192813
@joachim-danswer
further clean-up
901d8c2
@joachim-danswer
added streaming and small fixes
cc76486
@joachim-danswer
left or right
0333ff6
@joachim-danswer
all 3 options
568bc16
joachim-danswer and others added 25 commits January 7, 2025 13:50
@joachim-danswer
more renamings..
295417f
@joachim-danswer
more renamings
ef67f9c 
  follow_up -> refined
@evan-danswer
add message history to pro search config
682b145
@joachim-danswer
remove duplication of Main State keys + SubQuestion citation
1996e22
@evan-danswer
Merge branch 'search_2_0_evan_refactor_api' of https://github.com/ony…
8054285 
…x-dot-app/onyx into search_2_0_evan_refactor_api

merge
@evan-danswer
tiny testing change
5788902
@evan-danswer
merge with main
1849069
@evan-danswer
main merge
7ce0436
@evan-danswer
minor cleanup in preparation for Answer rework
79e7b73
@joachim-danswer
initial agent citation_processing
4c19b19
@evan-danswer
more minor cleanup
0bc3bb5
@evan-danswer
merge
969d027
@joachim-danswer
small fix
0d059cf
@evan-danswer
minor bug fix
8045d52
@evan-danswer
Merge branch 'search_2_0_evan_refactor_api' of https://github.com/ony…
44ccb5e 
…x-dot-app/onyx into search_2_0_evan_refactor_api

merge
@joachim-danswer
Added link for document citations
6ff439c 
 - assumes that Sub-question answers will follow the same citation format
 - assumes that we will be able to fit initial and revised answers into the same format.
@evan-danswer
yield docs after deduping and reranking, yield initial question docs
df75a31
@evan-danswer
Merge branch 'search_2_0_evan_refactor_api' of https://github.com/ony…
5f3e877 
…x-dot-app/onyx into search_2_0_evan_refactor_api
@evan-danswer
code cleanup
686eddf
@joachim-danswer
sub-question citation processing
685f12c
@joachim-danswer
Creation of AgentAnswerPiece class
d379453 
 - unifying sub-answers and main agent answers
@joachim-danswer
agent logging level change
aee625d
@joachim-danswer
created pro_search_a directory
4ab99fb 
 - moved all non-common files into that new directory to enable multiple graphs
@evan-danswer
initial movement of answer code (WIP)
635ba35
@evan-danswer
answer rework basic idea
89c60db
@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 9:27pm

@evan-danswer
Copy link
Contributor Author

switched to agent-search-feature for future development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evan-danswer @joachim-danswer @hagen-danswer