Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chrome extension pages #3629

Merged
merged 15 commits into from
Jan 15, 2025
Merged

Add chrome extension pages #3629

merged 15 commits into from
Jan 15, 2025

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Jan 8, 2025

Description

How Has This Been Tested?

  • Basic functionality like shortcuts, theme, etc.
  • Not logged in
    • Basic + new tab
    • Basic + side panel
    • Google + new tab
    • Google + side panel
    • Cloud + new tab
    • Cloud + side panel
  • No providers
    • Basic + new tab
    • Basic + side panel
    • Google + new tab
    • Google + side panel
    • Cloud + new tab
    • Cloud + side panel
  • Not the proper domain
    • Basic + new tab
    • Basic + side panel
    • Google + new tab
    • Google + side
    • Cloud + new tab
    • Cloud + side panel
  • Send a message
    • Basic + new tab
    • Basic + side panel
    • Google + new tab
    • Google + side
    • Cloud + new tab

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:39am

minor clean up

additional handling

post rebase fixes

nit

quick bump

finalize

minor cleanup

organizational

Revert changes in backend directory

Revert changes in deployment directory

push misc changes

improve shortcut display + general nrf page layout

minor clean up

quick nit

update chrome

k

build fix

k

update

k
@pablonyx pablonyx added this pull request to the merge queue Jan 15, 2025
@yuhongsun96 yuhongsun96 removed this pull request from the merge queue due to a manual request Jan 15, 2025
@yuhongsun96 yuhongsun96 merged commit 66d8b8b into main Jan 15, 2025
11 of 13 checks passed
@yuhongsun96 yuhongsun96 deleted the chrome_page branch January 15, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants