Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate Query History table #3592

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

skylares
Copy link
Contributor

@skylares skylares commented Jan 4, 2025

Changes:

  • Implemented server-side pagination for query history

    • Modified API endpoint to accept pagination parameters and return PaginatedReturn generic
    • Updated database queries from query to select
  • Improved feedback filtering system

    • Added "Mixed" feedback as a new filter option
    • Fixed feedback filters to strictly match their types (Like/Dislike)
    • Removed incorrect display of mixed feedback in single-type filters
  • Modified date range selector to make date range on initial load optional

  • Modified QueryHistoryTable to use the usePaginatedFetch hook

  • Added factory method from_chat_session() to transform ChatSession into ChatSessionMinimal

  • Fixed React key prop warning in development strict mode

  • Added test coverage

Issues:

  • If you send a message to an assistant and then quickly close the page an empty chat session is saved. It shows up fine on the query history table but gives an error when clicked.

Copy link

vercel bot commented Jan 4, 2025

@skylares is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant