Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the licence in the project metadata #1667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e10e3
Copy link
Contributor

@e10e3 e10e3 commented Jan 17, 2025

River did not mention its licence in the metadata, causing PyPi to have no information about it.

This new line will enable Poetry to add licence information when building a wheel.

@e10e3
Copy link
Contributor Author

e10e3 commented Jan 17, 2025

Something is broken on Github's side, the unit tests fail at the same place as in #1666. It can't fetch an URL's content for some reason.

Copy link
Member

@smastelini smastelini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e10e3
Copy link
Contributor Author

e10e3 commented Jan 20, 2025

It was not a problem on GitHub's side after all, OpenML.org is down: https://github.com/orgs/openml/discussions/20

@e10e3
Copy link
Contributor Author

e10e3 commented Jan 26, 2025

The OpenML server looks to be back online :)
If this is blocking the merge, is it possible to re-trigger the failing CI checks manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants