Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Coverity fixups #2380

Merged
merged 3 commits into from
Jan 18, 2025
Merged

[GPU] Coverity fixups #2380

merged 3 commits into from
Jan 18, 2025

Conversation

atkassen
Copy link
Contributor

@atkassen atkassen commented Jan 12, 2025 •
edited
Loading

Fixes a mistake in #2365/addresses the final Coverity hit from MFDNN-12963. Addresses MFDNN-12986.

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@atkassen atkassen added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Jan 12, 2025
@atkassen atkassen self-assigned this Jan 12, 2025
@atkassen atkassen requested a review from a team as a code owner January 12, 2025 22:35
@atkassen atkassen mentioned this pull request Jan 12, 2025
Merged
@atkassen
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_matmul

@atkassen atkassen changed the title xe: jit: gemm: fix signedness in arg to ilog2 [GPU] Coverity fixups Jan 13, 2025
@atkassen atkassen force-pushed the akassen/coverity-fixup branch from 171c3cc to 52e0108 Compare January 14, 2025 05:31
@atkassen
Copy link
Contributor Author

make test
disable test_device_cpu
disable build_cpu_runtime_omp
disable build_cpu_runtime_sycl
disable build_cpu_runtime_tbb
enable arch_gpu_xe-hpc
enable arch_gpu_xe-hpg-atsm
enable arch_gpu_xe-hpg-dg2
enable arch_gpu_xe-lp
enable arch_gpu_xe-lpg
enable arch_gpu_xe-lpg+
enable arch_gpu_xe2-hpg-bmg
enable arch_gpu_xe2-lpg
enable arch_gpu_xe3-lpg
disable benchdnn_all
enable benchdnn_matmul
enable benchdnn_pool
set test_scope=NIGHTLY

@atkassen
Copy link
Contributor Author

Orphaned CI

@atkassen atkassen force-pushed the akassen/coverity-fixup branch from 52e0108 to baa25bb Compare January 16, 2025 00:20
@atkassen
Copy link
Contributor Author

make test
disable test_device_cpu
disable build_cpu_runtime_omp
disable build_cpu_runtime_sycl
disable build_cpu_runtime_tbb
disable benchdnn_all
enable benchdnn_matmul
enable benchdnn_pool

@atkassen atkassen force-pushed the akassen/coverity-fixup branch from baa25bb to 3214f3a Compare January 16, 2025 18:11
@atkassen
Copy link
Contributor Author

make test
disable test_device_cpu
disable build_cpu_runtime_omp
disable build_cpu_runtime_sycl
disable build_cpu_runtime_tbb
disable benchdnn_all
enable benchdnn_matmul
enable benchdnn_pool

@atkassen
Copy link
Contributor Author

make test
disable test_device_cpu
disable build_cpu_runtime_omp
disable build_cpu_runtime_sycl
disable build_cpu_runtime_tbb
disable arch_gpu_xe-hpc
disable arch_gpu_xe-hpg-atsm
disable arch_gpu_xe-hpg-dg2
disable arch_gpu_xe-lp
disable arch_gpu_xe-lpg
enable arch_gpu_xe2-hpg-bmg
disable benchdnn_all
enable benchdnn_matmul
enable benchdnn_pool

@atkassen atkassen force-pushed the akassen/coverity-fixup branch from 3214f3a to c5e5321 Compare January 17, 2025 22:55
@atkassen atkassen merged commit 5c98ed0 into oneapi-src:main Jan 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kealan-barbieri kealan-barbieri kealan-barbieri approved these changes

@petercad petercad petercad approved these changes

Assignees

@atkassen atkassen

Labels
platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atkassen @petercad @kealan-barbieri