-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic] Refine migration of dim3 with helper function. #2025
Merged
zhimingwang36
merged 7 commits into
oneapi-src:SYCLomatic
from
tangjj11:dim3-ctor-in-class
Jul 8, 2024
Merged
[SYCLomatic] Refine migration of dim3 with helper function. #2025
zhimingwang36
merged 7 commits into
oneapi-src:SYCLomatic
from
tangjj11:dim3-ctor-in-class
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
approved these changes
May 31, 2024
tangjj11
force-pushed
the
dim3-ctor-in-class
branch
4 times, most recently
from
June 6, 2024 02:02
47efab0
to
ced32e3
Compare
AndyCHHuang
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tangjj11
force-pushed
the
dim3-ctor-in-class
branch
4 times, most recently
from
June 20, 2024 01:35
e21b03d
to
9aa34b6
Compare
tangjj11
force-pushed
the
dim3-ctor-in-class
branch
5 times, most recently
from
June 24, 2024 02:42
32dea94
to
f79d2bf
Compare
tangjj11
changed the title
[SYCLomatic] Fix migration bug of dim3 ctor in class.
[SYCLomatic] Refine migration of dim3 with helper function.
Jun 24, 2024
tangjj11
force-pushed
the
dim3-ctor-in-class
branch
2 times, most recently
from
June 24, 2024 08:32
058f591
to
0510e0d
Compare
ziranzha
approved these changes
Jun 25, 2024
tangjj11
force-pushed
the
dim3-ctor-in-class
branch
from
June 25, 2024 08:02
0510e0d
to
50bc68c
Compare
tangjj11
force-pushed
the
dim3-ctor-in-class
branch
from
July 4, 2024 10:15
ef82bf7
to
1da9a41
Compare
tangjj11
force-pushed
the
dim3-ctor-in-class
branch
from
July 5, 2024 02:11
1da9a41
to
35a4d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tang, Jiajun [email protected]