Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic] Refine migration of dim3 with helper function. #2025

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

tangjj11
Copy link
Contributor

Signed-off-by: Tang, Jiajun [email protected]

@tangjj11 tangjj11 requested a review from a team as a code owner May 31, 2024 07:51
@tangjj11 tangjj11 force-pushed the dim3-ctor-in-class branch 4 times, most recently from 47efab0 to ced32e3 Compare June 6, 2024 02:02
Copy link
Contributor

@AndyCHHuang AndyCHHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangjj11 tangjj11 force-pushed the dim3-ctor-in-class branch 4 times, most recently from e21b03d to 9aa34b6 Compare June 20, 2024 01:35
@tangjj11 tangjj11 force-pushed the dim3-ctor-in-class branch 5 times, most recently from 32dea94 to f79d2bf Compare June 24, 2024 02:42
@tangjj11 tangjj11 changed the title [SYCLomatic] Fix migration bug of dim3 ctor in class. [SYCLomatic] Refine migration of dim3 with helper function. Jun 24, 2024
@tangjj11 tangjj11 force-pushed the dim3-ctor-in-class branch 2 times, most recently from 058f591 to 0510e0d Compare June 24, 2024 08:32
@tangjj11 tangjj11 force-pushed the dim3-ctor-in-class branch from 0510e0d to 50bc68c Compare June 25, 2024 08:02
@tangjj11 tangjj11 force-pushed the dim3-ctor-in-class branch from ef82bf7 to 1da9a41 Compare July 4, 2024 10:15
@tangjj11 tangjj11 force-pushed the dim3-ctor-in-class branch from 1da9a41 to 35a4d65 Compare July 5, 2024 02:11
@zhimingwang36 zhimingwang36 merged commit e492a92 into oneapi-src:SYCLomatic Jul 8, 2024
22 checks passed
@tangjj11 tangjj11 deleted the dim3-ctor-in-class branch July 8, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants