Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid metadata for 2.0 branch #1195

Open
wants to merge 1 commit into
base: 2.0_branch
Choose a base branch
from
Open

Conversation

bact
Copy link

@bact bact commented Oct 27, 2024

So this can be used with pip >= 24.1

Motivation

omegaconf 2.0 requirements/base.txt has this line:

PyYAML>=5.1.*

which is considered an invalid metadata for pip >= 24.1, and makes it unable to install.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

If it can be installed with pip install . (or pip install omegaconf>2.0.6 (please change the version number to fit), it should be considered a pass.

Fixes

By change that line in requirements/base.txt to:

PyYAML>=5.1.0

So this can be used with pip >= 24.1

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Author

bact commented Oct 27, 2024

The checks failed at lint-3.6 with this message:

omegaconf/_utils.py:280: error: Returning Any from function declared to return "bool"
Found 1 error in 1 file (checked 41 source files)
nox > Session lint-3.6 failed.

The checks failed at lint-3.7 and lint-3.8 with this message:

ImportError while loading conftest '/home/circleci/project/tests/conftest.py'.
tests/init.py:6: in
import attr
E ModuleNotFoundError: No module named 'attr'
nox > Session coverage-3.8 failed.
nox > Running session lint-3.8

Also in 3.7 and 3.8, there's an error with Jupyter notebook at the coverage check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants