Fix invalid metadata for 2.0 branch #1195
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this can be used with pip >= 24.1
Motivation
omegaconf 2.0
requirements/base.txt
has this line:which is considered an invalid metadata for pip >= 24.1, and makes it unable to install.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
If it can be installed with
pip install .
(orpip install omegaconf>2.0.6
(please change the version number to fit), it should be considered a pass.Fixes
By change that line in
requirements/base.txt
to:hydra-core 1.0.7 depends on omegaconf<2.1 and >=2.0.5
Compatibility fix with Hydra 1.1 facebookresearch/fairseq#3722