fix: get_attr_data doesn't handle default factory correctly
#1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jasha10
reviewed
Nov 5, 2023
Jasha10
approved these changes
Nov 5, 2023
|
Hi, |
No, there's no ETA yet for the next Hydra release. |
|
@Jasha10, good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
get_attr_data()didn't check default values for "factory" types, which need to be called in order to get the real default value, so several use cases that worked with dataclasses were broken for attrs classes.Test Plan
New fixture parameter added for "factory" variant of the
tests/structured_conf/data/attrs classes, similar to the post-Python 3.11 dataclass tests.New test added for error on
takes_selfparameter to factory (does not exist in dataclasses).Fixes
Fixes #945
get_attr_datadoesn't handle default factory correctly