Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics improvement #31

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Metrics improvement #31

merged 8 commits into from
Mar 29, 2024

Conversation

lorenzoronzani
Copy link
Collaborator

  • Refactor of small things based on those discussed during the meeting.
  • Updated dashboards according to those used in the published version of grafana

Copy link
Member

@ilbertt ilbertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, well done!
I've left a few comments for some minor fixes. One is basically running:

cargo fmt

so that the files are formatted properly

src/gateway-state/Cargo.toml Outdated Show resolved Hide resolved
src/gateway-state/src/lib.rs Outdated Show resolved Hide resolved
src/gateway-state/src/lib.rs Outdated Show resolved Hide resolved
@ilbertt ilbertt added enhancement New feature or request bug Something isn't working labels Mar 29, 2024
@ilbertt ilbertt merged commit 4447c96 into main Mar 29, 2024
2 checks passed
@ilbertt ilbertt deleted the lorenzo branch March 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants