Fix order of the directory separators when downloading an image #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Ensure the internal repository path is applied after the fileset separator so that the internal structure is preserved and the data can be read by Bio-Formats.
The original change was introduced in #85 and exposed in OMERO.insight 5.8.4.
To test the fix, import filesets of different formats (see below) into OMERO and download them using the Java gateway i.e. either using OMERO.insight built with this change or with a standalone Java client like https://github.com/ome/minimal-omero-client. Without this change, the single-file filesets should be stored in a folder called
Fileset_<id>
but multi-file filesets will have their hierarchy inverted i.e. data<internal_folder>/Fileset_<id>
.With this change Bio-Formats should be able to read any downloaded fileset either using the command-line tools (
showinf
) or re-importing the data into the same server.Several file formats should likely be tested to confirm the fix is working in all scenarios. Excluding the HCS formats (which could also be tested but might require more time), minimally, the following set of formats should cover a set of layouts: