Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of the directory separators when downloading an image #90

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Aug 20, 2024

Fixes #89

Ensure the internal repository path is applied after the fileset separator so that the internal structure is preserved and the data can be read by Bio-Formats.

The original change was introduced in #85 and exposed in OMERO.insight 5.8.4.

To test the fix, import filesets of different formats (see below) into OMERO and download them using the Java gateway i.e. either using OMERO.insight built with this change or with a standalone Java client like https://github.com/ome/minimal-omero-client. Without this change, the single-file filesets should be stored in a folder called Fileset_<id> but multi-file filesets will have their hierarchy inverted i.e. data <internal_folder>/Fileset_<id>.

With this change Bio-Formats should be able to read any downloaded fileset either using the command-line tools (showinf) or re-importing the data into the same server.

Several file formats should likely be tested to confirm the fix is working in all scenarios. Excluding the HCS formats (which could also be tested but might require more time), minimally, the following set of formats should cover a set of layouts:

  • OME-TIFF (single file)
  • OME-TIFF (multi file)
  • VSI (multi file with multiple directories)
  • FV1000 (multi file with directory)

Ensure the internal repository path is applied after the fileset
separator so that the internal structure is preserved and the data
can be read by Bio-Formats
@sbesson sbesson requested review from jburel and dominikl August 20, 2024 10:13
@sbesson sbesson changed the title Fix order of the directory separator when download an image Fix order of the directory separators when downloading an image Aug 20, 2024
Copy link
Member

@dominikl dominikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Seb, looks good. Fixes the issue.

@jburel jburel merged commit ec68214 into ome:master Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug : download .vsi file/folder in 2 different folders
3 participants