Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port script to Python 3 #211

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Port script to Python 3 #211

merged 2 commits into from
Jan 23, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

I have checked that the script regenerates an identical specification/src/main/resources/transforms/ome-transforms.xml file.

Fixes #207.

It's mostly a matter of adding parentheses to `print`.
A004 Import is shadowing a Python builtin
@sbesson sbesson self-requested a review January 23, 2025 08:30
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(venv3.12) sbesson@Sebastiens-MacBook-Pro-3 transforms % python util/write-transforms.py > ome-transforms.xml               
(venv3.12) sbesson@Sebastiens-MacBook-Pro-3 transforms % git diff
(venv3.12) sbesson@Sebastiens-MacBook-Pro-3 transforms % 

Thank you @DimitriPapadopoulos

@sbesson sbesson merged commit aa8feb0 into ome:master Jan 23, 2025
12 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the transforms branch January 23, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specification/src/main/resources/transforms/util/write-transforms.py is still a Python 2 script
2 participants