Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license headers for all Java sources of the OME-XML library #181

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 10, 2023

While reviewing various boilerplate headers for BSD licensed projects, I noticed that several Java source files under the ome-xml component include the terms of the GNU GPL 2 license in their header which is at odds with the component license.

This is most certainly an oversight which can be traced back to the original introduction of the unit concept for the 2015-01 release of the OME Data model in ome/bioformats#1379.

This PR commits the changes after executing mvn license:update-file-header under the ome-xml component to fix the heders.

The only other notable difference is that the project name is updated from OME-XML Java library for working with OME-XML metadata structures. to OME XML library as per the POM file. If it is preferable to keep the existing header, happy to change the name in pom.xml

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to the updates, though likely a review of the pom.xml values and what's in the header would be worthwhile.

Copy link
Member

@dgault dgault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License updates all look good from my side.

The header updates for the project name look fine to me also. All the updated files are under the ome-xml folder so using OME XML library to match the POM seems correct.

@dgault dgault merged commit cfa912a into ome:master Dec 6, 2023
18 checks passed
@sbesson sbesson deleted the ome-xml_header_update branch December 6, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants