Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor for typescript strict mode #1237

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: Refactor for typescript strict mode #1237

merged 2 commits into from
Oct 25, 2024

Conversation

ke1v
Copy link
Collaborator

@ke1v ke1v commented Oct 25, 2024

Fixes and improvements for changes made in #1233

oliverschwendener
oliverschwendener approved these changes Oct 25, 2024
View reviewed changes
Copy link
Owner

@oliverschwendener oliverschwendener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I think it's time to finally add some tests for these classes

@oliverschwendener
Copy link
Owner

And if the class itself is doing too many things, then consider extracting some things into separate dedicated classes.

@oliverschwendener oliverschwendener enabled auto-merge (squash) October 25, 2024 13:29
@oliverschwendener oliverschwendener merged commit b9fa5cd into main Oct 25, 2024
2 checks passed
@oliverschwendener oliverschwendener deleted the fix/linux-appsearch branch October 25, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschwendener oliverschwendener oliverschwendener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ke1v @oliverschwendener