Trap focus key navigation in Select Range #4474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It probably makes more sense if we can always trap the focus when enabling Select Range, IMHO.
I often spam pressing arrow keys if not with
ctrl
to go to the side of the table. But since tabulator doesn't call.preventDefault
at certain condition, it instead does something else to the page. For example, it scrolls the page instead of staying in position, and in my browser, it can go to the previous page (by pressingCtrl+Left
).To replicate:
left/right/up/down
repeatedlyThis fix can be very helpful too especially if a browser or an app has a custom keybinding. In my browser, I use
Ctrl+Left/Right
for going to previous/next page. It's annoying that I often accidently change my page when I no longer can go left and I pressCtrl+Left
.