Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute credential process to get temporary credentials. #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

perplexes
Copy link

At work we use credential_process inside of ~/.aws/credientials, with a profile for each app/env combo so that we don't have to manually manage our AWS credentials. This adds support for using this directive: Get the command, execute in subshell to obtain JSON, parse json, and extract access key, secret, and session.

Follows https://github.com/aws/aws-cli/blob/ecd654bb665a29246496e6dcac33e24a60d6cf7a/awscli/topics/config-vars.rst#sourcing-credentials-from-external-processes

@okigan
Copy link
Owner

okigan commented Oct 31, 2020 via email

@lugoues
Copy link

lugoues commented Nov 2, 2020

This should really rely on boto to get temporary credentials. A lot of people, myself included, use credential_process to fetch master credentials that are then used by the api to assume a role.

This is partially related to #44. Which itself is an issue since it obfuscates the fact that it isn't following the standard methods to obtain credentials.

@okigan
Copy link
Owner

okigan commented Nov 10, 2020

@perplexes So oddly enough it's failing continuous builds for ubuntu 3.6,3.8 -- which unclear why to me. Secondary PR is missing update to readme to indicate how to use this. Could you update the PR? Huge thanks!

I've added a branch to test the CI loop -- it's passing: https://github.com/okigan/awscurl/runs/1381017691?check_suite_focus=true

But the one for this PR is failing (capturing snapshot below):
image

@fugkco
Copy link

fugkco commented Nov 15, 2021

@okigan could this get looked at and/or merged? We're starting to credential process too, it's much more convenient and allows for credentials to never be written to disk.

@okigan
Copy link
Owner

okigan commented Apr 26, 2023

@perplexes I've updated your PR to pass tests, but I wanted to check if it is still needed, as #146 was already merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants